Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement implicit field size alignment #33

Merged
merged 3 commits into from
Mar 9, 2020
Merged

Implement implicit field size alignment #33

merged 3 commits into from
Mar 9, 2020

Conversation

pavel-kirienko
Copy link
Member

@pavel-kirienko pavel-kirienko self-assigned this Mar 6, 2020
@coveralls
Copy link

coveralls commented Mar 6, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 296

  • 29 of 29 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 29942788: 0.0%
Covered Lines: 2930
Relevant Lines: 2930
💛 - Coveralls

@pavel-kirienko pavel-kirienko mentioned this pull request Mar 6, 2020
Merged
@pavel-kirienko
Copy link
Member Author

Not sure what happened to Coveralls here.

thirtytwobits
thirtytwobits reviewed Mar 9, 2020
View reviewed changes
Copy link
Member

@thirtytwobits thirtytwobits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test where the calculated length is 16?

@pavel-kirienko pavel-kirienko merged commit 897762d into master Mar 9, 2020
@pavel-kirienko pavel-kirienko deleted the implicit-field-size-alignment branch March 9, 2020 18:28
pavel-kirienko added a commit to OpenCyphal/nunavut that referenced this pull request Mar 9, 2020
@pavel-kirienko
Use PyDSDL v1.2
4ec8d7e 
OpenCyphal/pydsdl#33
@pavel-kirienko pavel-kirienko mentioned this pull request Mar 9, 2020
Merged
thirtytwobits pushed a commit to OpenCyphal/nunavut that referenced this pull request Mar 12, 2020
@pavel-kirienko
Use PyDSDL v1.2 (#106)
9910428 
* Use PyDSDL v1.2

OpenCyphal/pydsdl#33

* Update the regulated DSDL submodule

* Update version.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thirtytwobits thirtytwobits thirtytwobits approved these changes

Assignees

@pavel-kirienko pavel-kirienko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavel-kirienko @coveralls @thirtytwobits